Get thumbnail attachment shell - #198
Merged
Merged
Conversation
…nhance asset ID queries
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Refactor the return statement in `SubmodelRepositoryService.cs` to use the C# 8.0 range operator for improved collection handling. Add comprehensive unit tests in `GetAllSubmodelsControllerTests.cs` to cover various scenarios for the `GetAllSubmodelsAsync` method, including handling of query parameters, paging, and exception cases. Utilize `NSubstitute` for mocking and `Xunit` for test structuring.
…th semaphore and add configuration for concurrent operations limit
Introduce `_templateManagementOptions` in `SubmodelRepositoryServiceTests` to configure `TemplateManagementConfig` with a `ServiceInstance` and `ConcurrentOperationsLimit`. Update the constructor of `SubmodelRepositoryService` to include the new parameter. Add necessary using directives for configuration and options handling.
…tAllSubmodelsAsync functionality and improve request handling
…mplateAsync and adjust request paths
…SubmodelTemplateAsync for improved query handling
…cluding adjustments to semaphore release and data structure initialization.
…SuccessStatusCode with explicit check for success status and throw InternalDataProcessingException on failure.
Replaces direct HTTP streaming with IFileContentProvider and FileAttachmentResult abstractions. Controller now uses FileContentStreamResult with OpenTelemetry tracing. Improves error handling for invalid URLs and removes obsolete code and dependencies. Updates usings for consistency.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…ovider with IFileContentProvider and update related methods
…viders with Shared.Providers and update related services
…ean up file content provider by removing unused content type variable
…sts: update expected content type to application/octet-stream and streamline file content retrieval
mm-omdi
marked this pull request as ready for review
August 7, 2026 07:59
…elated tests; streamline constructor syntax in AasRepositoryHandlerTests
mm-omdi
changed the title
…mock thumbnail with expected asset information template and update content type assertion
…ent type handling
mm-asha
changed the title
…it tests for attachment handling
…remove unused using directive in FileContentStreamResult
…in FileContentStreamResultTests
…se switch statement for clarity
…ure proper attachment case is processed
mm-asha
previously approved these changes
Aug 12, 2026
|
mm-hsh
self-requested a review
August 12, 2026 04:52
mm-hsh
approved these changes
Aug 12, 2026
Test & Coverage ReportTest Results Summary
Code CoverageUnit Tests Coverage
Minimum allowed line rate is Module Tests Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces and tests the new "Get Thumbnail By Id" API endpoint for the AAS Repository, which allows clients to retrieve the thumbnail image for a given Asset Administration Shell (AAS) by its identifier. The changes include the addition of example API requests, new unit and integration tests, and necessary dependency injections to support streaming thumbnail files.
Key changes include:
API Additions
Get Thumbnail By Id.bru) for different products in the API collection, demonstrating how to call the new thumbnail endpoint with various AAS identifiers. [1] [2] [3]Integration and Unit Testing
AasRepositoryControllerTests.csto verify:AasRepositoryControllerTests.cs,AasRepositoryHandlerTests.cs, andAasRepositoryServiceTests.csto ensure:Dependency Injection and Mocks
IFileAttachmentStreamProviderin test setups to support streaming thumbnail files in tests. [1] [2] [3] [4]IHttpContextAccessorand configuration options for file attachment size. [1] [2]Minor Improvements
These changes ensure the new thumbnail retrieval endpoint is robustly covered by tests and ready for integration.